fix: [issues-245] escape Rich markup in logging to prevent MarkupError crashes#246
Open
miiiak wants to merge 1 commit intoawslabs:mainfrom
Open
fix: [issues-245] escape Rich markup in logging to prevent MarkupError crashes#246miiiak wants to merge 1 commit intoawslabs:mainfrom
miiiak wants to merge 1 commit intoawslabs:mainfrom
Conversation
When model responses or AWS SDK debug logs contain square brackets (e.g. regex patterns like [/\s]), Rich's RichHandler interprets them as markup tags and throws MarkupError, crashing the CLI mid-run. Changes: - Escape record.getMessage() in AgentAwareFormatter using rich_escape() - Add _rich_markup_safe flag for app's own styled helper functions - Isolate strands/botocore/boto3/urllib3/s3transfer loggers with markup=False handlers and propagate=False Fixes awslabs#245
miiiak
force-pushed
the
fix/rich-markup-error-logging
branch
from
57b67a4 to
6e63cef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When model responses or AWS SDK debug logs contain square brackets (e.g. regex patterns like [/\s]), Rich's RichHandler interprets them as markup tags and throws MarkupError, crashing the CLI mid-run.
Proposed fix for #245
Issue #, if available: #245
Description of changes: :
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.