[AD] Fix race condition in AD 1-click template that caused stack creation failure#7348
Merged
gmarciani merged 1 commit intoaws:developfrom Apr 22, 2026
Merged
Conversation
…tion failure. The fix consists making the Post custom resource wait for the AdAdminNode to complete the registration of users.
hehe7318
approved these changes
Apr 22, 2026
gmarciani
added
skip-changelog-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix race condition in AD 1-click template that caused stack creation failure by making the Post custom resource wait for the AdAdminNode to complete the registration of users.
The Post custom resource executes operations on AD users, which are created by the AdAdminNode. So it requires the AdAdminNode to complete its user data. So far the custom resource depends on AdAdminNode, but this is not enough because CloudFormation considered the EC2 instance created as soon as it launched, which unblocks the custom resource too early. To make the custom resource wait for the node3 to complete its user data, the custom resource must waith for the wait condition signaled by the end of the user data.
Tests
SUCCESS
test_ad_integrationBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.