fix: show helpful error when docker is missing during bundling fallback#37521
fix: show helpful error when docker is missing during bundling fallback#37521
Conversation
when esbuild is not installed locally, cdk falls back to docker bundling. if docker is also missing, the error was just 'spawnSync docker ENOENT' which is confusing - now it tells users what's actually wrong and suggests installing esbuild to skip docker entirely. fixes aws#22997
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Exemption Request this change only improves an error message when docker is not found (ENOENT) during asset bundling - it doesn't change any cloudformation output or runtime behavior. an integration test for this would require docker to not be installed, which doesn't make sense in a normal test environment. the fix is fully covered by unit tests in requesting |
Summary
spawnSync docker ENOENTerrorTest plan
fixes #22997