Skip to content

fix(cloudfront): warn when minimumProtocolVersion is set without custom certificate#37483

Open
syukawa-gh wants to merge 2 commits intoaws:mainfrom
syukawa-gh:fix/cloudfront-min-protocol-validation
Open

fix(cloudfront): warn when minimumProtocolVersion is set without custom certificate#37483
syukawa-gh wants to merge 2 commits intoaws:mainfrom
syukawa-gh:fix/cloudfront-min-protocol-validation

Conversation

@syukawa-gh
Copy link
Copy Markdown
Contributor

Closes #35404
The minimumProtocolVersion property is only applicable when a custom SSL/TLS certificate is configured. Added a warning annotation.
Exemption Request: Warning annotation only, no CloudFormation output change.

…om certificate

The minimumProtocolVersion property is only applicable when a custom
SSL/TLS certificate is configured. Without a certificate, CloudFront
ignores this setting and uses its default security policy.

Closes aws#35404
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Apr 1, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team April 1, 2026 10:25
@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Apr 1, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

@syukawa-gh
Copy link
Copy Markdown
Contributor Author

Exemption Request: This fix adds a synth-time validation warning when minimumProtocolVersion is set without a custom certificate. Unit tests are included. Integration test is not applicable as this is a synth-time warning, not a CloudFormation output change.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Apr 2, 2026
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 2, 2026
@syukawa-gh
Copy link
Copy Markdown
Contributor Author

Correction to my previous comment: After reviewing the diff more carefully, this PR needs unit tests to be added. I will update this PR with the required tests. The Exemption Request above should be disregarded for the unit test requirement.

@syukawa-gh
Copy link
Copy Markdown
Contributor Author

To clarify my earlier comments: unit tests are already included in this PR. The "Correction" comment above was posted in error. The exemption request is for the integration test only — this is a synth-time validation warning that does not change CloudFormation output, and the unit tests verify the warning is emitted correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr/needs-maintainer-review This PR needs a review from a Core Team Member pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cloudfront: minimumProtocolVersion setting should not be allowed without custom SSL/TLS certificate

3 participants