Skip to content

Add nvidia driver version checks to GH actions#434

Merged
harishxr merged 1 commit intoaws:mainfrom
harishxr:nvidia-version
May 15, 2025
Merged

Add nvidia driver version checks to GH actions#434
harishxr merged 1 commit intoaws:mainfrom
harishxr:nvidia-version

Conversation

@harishxr
Copy link
Copy Markdown
Contributor

Summary

This PR enhances the GitHub action workflow to improve NVIDIA driver update detection and version tracking for both AL2 and AL2023 GPU AMIs. Key improvements include:

  • Reliable update detection for both AL2 and AL2023 GPU drivers
  • Version tracking system for NVIDIA drivers
  • Separate handling of AL2023 GPU checks due to deterministic updates
  • Combined security and NVIDIA package update checks for AL2 GPU AMIs

Implementation details

Changes to check-update.sh:

  • Added version tracking functionality through handle_nvidia_version function
  • Moved AL2023 GPU checks outside the dependency diff check due to deterministic updates
  • Enhanced AL2 GPU checks to detect both security and NVIDIA package updates
  • Implemented version extraction and storage in NVIDIA_DRIVER_VERSION file

Changes to check-update-security.sh:

  • Added support for AL2023 GPU AMI checks using dnf
  • Implemented retry mechanism with cache cleaning for reliable update detection
  • Enhanced version extraction logic for both AL2 and AL2023 GPU drivers
  • Added proper error handling and logging

Version Tracking:

  • Created NVIDIA_DRIVER_VERSION file to track driver versions

Testing

Ran ./scripts/check-update.sh al2023 and ./scripts/check-update.sh al2 manually and verified that they work.
New tests cover the changes: no

Description for the changelog

Add nvidia driver version checks to GH actions

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harishxr harishxr requested a review from a team as a code owner May 13, 2025 17:55
@harishxr harishxr force-pushed the nvidia-version branch 3 times, most recently from 58dbc25 to 792cb3d Compare May 13, 2025 18:01
Comment thread scripts/check-update-security.sh
ShelbyZ
ShelbyZ previously approved these changes May 13, 2025
Comment thread scripts/check-update-security.sh Outdated
Comment thread NVIDA_DRIVER_VERSION
@harishxr harishxr force-pushed the nvidia-version branch 4 times, most recently from 432d489 to 67f3a30 Compare May 14, 2025 00:00
Comment thread scripts/check-update.sh Outdated
@harishxr harishxr force-pushed the nvidia-version branch 2 times, most recently from c70352b to 970432f Compare May 14, 2025 16:14
Comment thread scripts/check-update-security.sh
Comment thread scripts/check-update.sh Outdated
Comment thread scripts/check-update.sh Outdated
@harishxr harishxr force-pushed the nvidia-version branch 6 times, most recently from 2e23485 to b1143ad Compare May 14, 2025 23:09
Copy link
Copy Markdown
Contributor

@singholt singholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

I suggest running shfmt once to double check formatting: https://github.com/mvdan/sh. We should probably have a PR check for it.

@harishxr harishxr merged commit f9a5050 into aws:main May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants