Add nvidia driver version checks to GH actions#434
Merged
Conversation
58dbc25 to
792cb3d
Compare
ShelbyZ
reviewed
May 13, 2025
ShelbyZ
previously approved these changes
May 13, 2025
432d489 to
67f3a30
Compare
prateekchaudhry
previously approved these changes
May 14, 2025
c70352b to
970432f
Compare
singholt
reviewed
May 14, 2025
singholt
reviewed
May 14, 2025
singholt
reviewed
May 14, 2025
2e23485 to
b1143ad
Compare
singholt
approved these changes
May 15, 2025
Contributor
There was a problem hiding this comment.
🚀 🚀
I suggest running shfmt once to double check formatting: https://github.com/mvdan/sh. We should probably have a PR check for it.
ShelbyZ
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the GitHub action workflow to improve NVIDIA driver update detection and version tracking for both AL2 and AL2023 GPU AMIs. Key improvements include:
Implementation details
Changes to check-update.sh:
handle_nvidia_versionfunctionNVIDIA_DRIVER_VERSIONfileChanges to check-update-security.sh:
Version Tracking:
NVIDIA_DRIVER_VERSIONfile to track driver versionsTesting
Ran
./scripts/check-update.sh al2023and./scripts/check-update.sh al2manually and verified that they work.New tests cover the changes: no
Description for the changelog
Add nvidia driver version checks to GH actions
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.