Fix schema false positives and add VirtualName validation rules#4456
Open
kddejong wants to merge 1 commit intoaws-cloudformation:mainfrom
Open
Fix schema false positives and add VirtualName validation rules#4456kddejong wants to merge 1 commit intoaws-cloudformation:mainfrom
kddejong wants to merge 1 commit intoaws-cloudformation:mainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
==========================================
- Coverage 93.54% 93.44% -0.11%
==========================================
Files 418 452 +34
Lines 14145 14886 +741
Branches 2817 2891 +74
==========================================
+ Hits 13232 13910 +678
- Misses 567 597 +30
- Partials 346 379 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kddejong
force-pushed
the
fix/schema-false-positives
branch
4 times, most recently
from
17838d9 to
8fe5fe4
Compare
Schema corrections: - AmazonMQ::Broker: Use enumCaseInsensitive for StorageType (accepts efs/EFS) - CloudFormation::StackSet: Allow / in ExecutionRoleName for IAM role paths - Bedrock::Guardrail: Increase RegexesConfig maxItems from 10 to 30 - MSK::Cluster: Remove NumberOfBrokerNodes maximum (adjustable quota) - Lambda::Function: Remove global Layers maxLength, add regional rule E3716 - Logs::LogAnomalyDetector: Add * to LogGroupArnList pattern for ARN wildcards - EC2::NetworkInterface: Add interface to InterfaceType enum - AutoScaling::ASG: Replace HealthCheckType enum with pattern for comma-separated values - Backup::BackupSelection: Remove 50-char length limit from SelectionName pattern - Glue::Job: Remove NumberOfWorkers maximum (adjustable quota) New rules: - E3715: Validate VirtualName requires ephemeralN format when no Ebs specified - W3698: Warn on non-ephemeral VirtualName alongside Ebs block device - E3716: Regional Lambda layer ARN maxLength validation (commercial regions only) Bug fixes: - Fix update_specs_from_pricing.py crash on None instanceType from pricing API - Add skip_resource_property_paths to smithy script for per-resource overrides - Regenerate manual patches via update_schemas_manually.py
kddejong
force-pushed
the
fix/schema-false-positives
branch
from
8fe5fe4 to
4eeacfe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Schema corrections
/in ExecutionRoleName for IAM role paths*to LogGroupArnList pattern for ARN wildcardsinterfaceto InterfaceType enumNew rules
Bug fixes
update_specs_from_pricing.pycrash on None instanceType from pricing APIskip_resource_property_pathsto smithy script for per-resource overridesupdate_schemas_manually.py