Skip to content

Add an additional + for ssm pattern#4062

Merged
kddejong merged 1 commit intoaws-cloudformation:mainfrom
kddejong:fix/ssm/parameter/name/pattern
Apr 2, 2025
Merged

Add an additional + for ssm pattern#4062
kddejong merged 1 commit intoaws-cloudformation:mainfrom
kddejong:fix/ssm/parameter/name/pattern

Conversation

@kddejong
Copy link
Copy Markdown
Contributor

@kddejong kddejong commented Apr 2, 2025

Issue #, if available:
fix #4061
Description of changes:

  • Add an additional + for ssm pattern

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong changed the title Forgot an additional + for ssm pattern Add an additional + for ssm pattern Apr 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (4eeec9a) to head (819163c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4062      +/-   ##
==========================================
- Coverage   94.19%   94.18%   -0.01%     
==========================================
  Files         386      386              
  Lines       13335    13335              
  Branches     2643     2643              
==========================================
- Hits        12561    12560       -1     
  Misses        422      422              
- Partials      352      353       +1     
Flag Coverage Δ
unittests 94.17% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kddejong kddejong merged commit 534a22a into aws-cloudformation:main Apr 2, 2025
22 checks passed
@kddejong kddejong deleted the fix/ssm/parameter/name/pattern branch April 2, 2025 17:52
@matsuu
Copy link
Copy Markdown

matsuu commented Apr 8, 2025

The regex doesn't match /example. I suggest replacing + with *.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

W1031: SSM parameter name does not match regex when using !Sub

2 participants