feat(keyboard): add group support for append_client_keybindings#4079
Merged
mergify[bot] merged 1 commit intoawesomeWM:masterfrom Mar 17, 2026
Merged
feat(keyboard): add group support for append_client_keybindings#4079mergify[bot] merged 1 commit intoawesomeWM:masterfrom
mergify[bot] merged 1 commit intoawesomeWM:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4079 +/- ##
==========================================
- Coverage 90.47% 90.46% -0.01%
==========================================
Files 940 941 +1
Lines 60359 60391 +32
Branches 1145 1145
==========================================
+ Hits 54609 54635 +26
- Misses 5243 5249 +6
Partials 507 507
🚀 New features to boost your workflow:
|
Member
|
please add a test |
Contributor
Author
To be honest, I don't know how to add it, and I haven't found any precedents yet. I modified an existing one—see if it works for you. |
actionless
reviewed
Mar 13, 2026
Aire-One
reviewed
Mar 16, 2026
Comment on lines
+178
to
+180
| -- @tparam table keys A table of `awful.key` objects. Optionally, it can have | ||
| -- a `group` entry. If set, the `group` property will be set on all `awful.keys` | ||
| -- objects. |
Member
There was a problem hiding this comment.
(I can see this is copied from module.append_global_keybindings) Maybe it should be documented as its own parameter: @tparam[opt] string keys.group If set, ...
actionless
approved these changes
Mar 17, 2026
Aire-One
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primarily to align with the append_global_keybindings behavior.
This feature is indeed useful, as it reduces some boilerplate code.