Skip to content

feat(keyboard): add group support for append_client_keybindings#4079

Merged
mergify[bot] merged 1 commit intoawesomeWM:masterfrom
cnjhb:keybindings
Mar 17, 2026
Merged

feat(keyboard): add group support for append_client_keybindings#4079
mergify[bot] merged 1 commit intoawesomeWM:masterfrom
cnjhb:keybindings

Conversation

@cnjhb
Copy link
Copy Markdown
Contributor

@cnjhb cnjhb commented Mar 11, 2026

Primarily to align with the append_global_keybindings behavior.
This feature is indeed useful, as it reduces some boilerplate code.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (81b1efa) to head (b9768b7).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4079      +/-   ##
==========================================
- Coverage   90.47%   90.46%   -0.01%     
==========================================
  Files         940      941       +1     
  Lines       60359    60391      +32     
  Branches     1145     1145              
==========================================
+ Hits        54609    54635      +26     
- Misses       5243     5249       +6     
  Partials      507      507              
Files with missing lines Coverage Δ
lib/awful/keyboard.lua 92.95% <100.00%> (+3.25%) ⬆️
tests/examples/awful/screenshot/keybindings1.lua 98.41% <100.00%> (+0.02%) ⬆️

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@actionless
Copy link
Copy Markdown
Member

please add a test

@cnjhb
Copy link
Copy Markdown
Contributor Author

cnjhb commented Mar 13, 2026

please add a test

To be honest, I don't know how to add it, and I haven't found any precedents yet. I modified an existing one—see if it works for you.

Comment thread tests/examples/awful/screenshot/keybindings1.lua
@cnjhb cnjhb requested a review from actionless March 16, 2026 01:30
Copy link
Copy Markdown
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

actionless
actionless previously approved these changes Mar 16, 2026
Copy link
Copy Markdown
Member

@actionless actionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 👌😸

Comment thread lib/awful/keyboard.lua Outdated
Comment on lines +178 to +180
-- @tparam table keys A table of `awful.key` objects. Optionally, it can have
-- a `group` entry. If set, the `group` property will be set on all `awful.keys`
-- objects.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I can see this is copied from module.append_global_keybindings) Maybe it should be documented as its own parameter: @tparam[opt] string keys.group If set, ...

Copy link
Copy Markdown
Member

@Aire-One Aire-One left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cnjhb

@mergify mergify Bot merged commit f1388f9 into awesomeWM:master Mar 17, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants