Skip to content

migration_with_memory_devices: set start_vm = no to fix 'Domain is ready active'#6869

Open
BulaYoungR wants to merge 1 commit into
autotest:masterfrom
BulaYoungR:fix/migration-with-memory-devices-start-vm-no
Open

migration_with_memory_devices: set start_vm = no to fix 'Domain is ready active'#6869
BulaYoungR wants to merge 1 commit into
autotest:masterfrom
BulaYoungR:fix/migration-with-memory-devices-start-vm-no

Conversation

@BulaYoungR
Copy link
Copy Markdown

@BulaYoungR BulaYoungR commented May 12, 2026

migration_obj.setup_connection() calls setup_default(), which already starts the VM when start_vm == "yes" (the default). The test then runs vm.start() in TEST_STEP2 and fails with:

VMStartError: VM 'avocado-vt-vm1' failed to start:
error: Domain is already active (exit status: 1)

Set start_vm = no at the test-class scope so setup_default() leaves the VM shut off, and the explicit vm.start() in TEST_STEP2 remains the single start point.

Summary by CodeRabbit

  • Tests
    • Updated migration test configuration for memory device scenarios to control VM startup behavior.

Review Change Stack

…ready active'

migration_obj.setup_connection() calls setup_default(), which already starts
the VM when start_vm == "yes" (the default). The test then runs vm.start()
in TEST_STEP2 and fails with:

  VMStartError: VM 'avocado-vt-vm1' failed to start:
    error: Domain is already active (exit status: 1)

Set start_vm = no at the test-class scope so setup_default() leaves the VM
shut off, and the explicit vm.start() in TEST_STEP2 remains the single
start point.

Signed-off-by: Bolatbek Issakh <bissakh@redhat.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4ad75fed-f414-4fbc-94fd-3923f5f07197

📥 Commits

Reviewing files that changed from the base of the PR and between c96ab65 and bcf8118.

📒 Files selected for processing (1)
  • libvirt/tests/cfg/migration/migration_with_memory/migration_with_memory_devices.cfg

Walkthrough

A configuration setting is added to the migration with memory devices test scenario, setting start_vm = no to prevent automatic VM startup for this specific test case.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the specific configuration change (setting start_vm = no) and its purpose (fixing 'Domain is already active' error), accurately reflecting the main change in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@harvey0100
Copy link
Copy Markdown

Closing this PR due to current team constraints. This is part of a broader effort to triage all in-flight work across our upstream repos. If this work is still needed, please feel free to reopen and it will be picked up. Apologies for any inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants