Refactor/remove bs4 dependency#161
Merged
thalissonvs merged 4 commits intoautoscrape-labs:mainfrom Jun 18, 2025
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
thalissonvs
approved these changes
Jun 18, 2025
Member
|
Thanks @Marcusfam-RB, it's perfect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring Pull Request
Refactoring Scope
Refactored internal HTML text extraction logic by removing
BeautifulSoupdependancy and using custom implementation.Related Issue(s)
Resolves #154
Description
Removed
BeautifulSoupdependancy, previously usedget_text()method replaced with customextract_text_from_htmlmethod inutils.py, that uses newTextExtractorclass to extract text from HTML. New class is based on HTMLParser from built-inhtmllibrary. This class replicates the behavior ofBeautifulSoup.get_text(), including:<script>,<style>, and<template>stripto trim whitespace from each text nodeseparatorto join text fragmentsMotivation
Reduce external dependencies,
BeautifulSoupwas only used forget_text()method.Performance Impact
Technical Debt
API Changes
Testing Strategy
Testing Checklist
Checklist before requesting a review
poetry run task lintand fixed any issuespoetry run task testand all tests pass