Conversation
| @@ -0,0 +1,41 @@ | |||
| package anima_raylib | |||
There was a problem hiding this comment.
This should probably be anima_karl2d right? :)
| package anima_raylib | ||
|
|
||
| import ".." | ||
| import k2 "../../../karl2d" |
There was a problem hiding this comment.
This gives me a bit of head scratching because this forces us to have karl2d beside anima in the file tree but I'm also not sure if there even is a better solution 🤔
A super random idea would be:
import k2 "karl2d:."and then when building you can pick the path yourself using
$ odin run . -collection:karl2d="../../../karl2d"Do you have another idea? I'm not yet sure if this is a good idea, but I'd prefer if we don't have to hardcode the path (even though this seems like a very sensible standard)
There was a problem hiding this comment.
No, unfortunately I can't think of a clean way to do this for a non-vendored library. I like your idea as well instead of needing karl2d in the parent directory. Either way will require some explanation in the README. I will defer to your preference.
|
Thanks for the pull request, looks very good overall :)! |
Yes, karl2d currently has a bug that causes blurry text with a zoomed camera. I had tried to keep the commands mapped 1:1 with the raylib example, but I think I agree that it's better to render a cleaner example. I can make the change to not include text in the camera view, along with the package deceleration correction. |
2 participants
Add support for the karl2d library