This repository was archived by the owner on Mar 11, 2025. It is now read-only.
[DONT MERGE] Always take reference when accessing value passed as argument to a macro#714
Draft
msrd0 wants to merge 2 commits intoaskama-rs:mainfrom
Draft
[DONT MERGE] Always take reference when accessing value passed as argument to a macro#714msrd0 wants to merge 2 commits intoaskama-rs:mainfrom
msrd0 wants to merge 2 commits intoaskama-rs:mainfrom
Conversation
Collaborator
|
Sorry, I don't have much time for this so if you want more help can you comment here with some of the generated code and point out where/why the problem happens? |
Contributor
Author
|
It fails because it cannot compare |
Kijewski
force-pushed
the
main
branch
2 times, most recently
from
5633250 to
704f8f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was proposed by @djc to fix #708 - but just blindly taking references does not seem to work