Skip to content
This repository was archived by the owner on Mar 11, 2025. It is now read-only.

Two fixes for working with heritages#604

Merged
djc merged 2 commits intoaskama-rs:mainfrom
Kijewski:pr-heritage
Jan 12, 2022
Merged

Two fixes for working with heritages#604
djc merged 2 commits intoaskama-rs:mainfrom
Kijewski:pr-heritage

Conversation

@Kijewski
Copy link
Copy Markdown
Member

  • &Option<T> is an antipattern
  • the HashMap's hasher should be always or never configurable

Extracted fixes from #600, which are useful on their own.

In askama_shared::generate a custom hasher for the contexts can be
given, so Heritage needs to accept the argument to.
@djc djc merged commit cb1b28f into askama-rs:main Jan 12, 2022
@Kijewski Kijewski deleted the pr-heritage branch January 12, 2022 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants