This repository was archived by the owner on Mar 11, 2025. It is now read-only.
Replace &PathBuf with &Path#602
Merged
djc merged 1 commit intoaskama-rs:mainfrom Jan 24, 2022
Kijewski:pr-no-ref-pathbuf
Merged
Replace &PathBuf with &Path#602djc merged 1 commit intoaskama-rs:mainfrom Kijewski:pr-no-ref-pathbuf
&PathBuf with &Path#602djc merged 1 commit intoaskama-rs:mainfrom
Kijewski:pr-no-ref-pathbuf
Conversation
Collaborator
|
The |
Collaborator
|
Ugh, that's still pretty ugly. I'll see if I can play with this tomorrow. |
Member
Author
|
I'd actually say I made it worse. :D |
Collaborator
|
Yeah, okay, would you mind going back to using |
PathBuf is to String like Path is to str, so `&PathBuf` is a pointer to a pointer. Clippy does not likes that.
djc
approved these changes
Jan 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathBuf is to String like Path is to str, so
&PathBufis a pointer to a pointer. Clippy does not likes that.In #600 clippy did notice the problem after some refactoring. This change is at least a little useful on its own.