feat: convert link to reference#399
Open
bennypowers wants to merge 9 commits intoartempyanykh:mainfrom
Open
Conversation
Author
|
checks and compiles but apparently doesn't run 🤷 |
Author
|
Ok, now there are passing tests, but it still doesn't convert link in README. Hoping maintainers can give me some advice here |
adds tests
- Return domain type (MultiEditAction) instead of LSP CodeAction, matching the pattern used by tableOfContents and createMissingFile - Fix unsafe Option.Value call by proper pattern matching - Fix reference definition range to insert at document end with proper newline separation - Fix range containment check to use ContainsInclusive instead of line-only comparison - Include link title in generated reference definitions - Add default.marksman.toml entry for link_to_reference config - Add comprehensive tests: cursor not on link, cursor on reference link, link without URL, link with title, multiple links, and single-link document Assisted-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bennypowers
force-pushed
the
feat/convert-to-reference
branch
from
f69c64c to
28d546e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #104
My f# experience consists entirely of:
So please review carefully