update the distinct active state for the Job and Job Sets tab#4887
update the distinct active state for the Job and Job Sets tab#4887
Conversation
5fb438c to
5877261
Compare
Greptile SummaryThis PR adds a visible active-state indicator to the Jobs and Job Sets navigation buttons by wiring up React Router's
Confidence Score: 5/5Safe to merge — purely additive UI styling with no impact on data or routing logic beyond the end fix for the root path. The end: true fix for the JOBS route correctly prevents the root path from prefix-matching every URL now that the active class has a visible effect. The CSS variable is properly inherited from the styled AppBar, and the end prop is correctly forwarded through the NavLinkButton spread. No data paths, API calls, or auth flows are touched. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User navigates to URL] --> B{Current path}
B -->|exactly /| C[JOBS NavLink end=true - React Router adds .active class]
B -->|starts with /job-sets| D[JOB SETS NavLink - React Router adds .active class]
B -->|any other path| E[Neither NavLink is active]
C --> F[CSS applies nav-active-bg background and bold font]
D --> F
F --> G[Active tab visually highlighted]
E --> H[No highlight shown]
Reviews (4): Last reviewed commit: "chore: update based on comments" | Re-trigger Greptile |
Signed-off-by: Yasmine Hines <[email protected]>
…off-by: Yasmine Hines [email protected] Signed-off-by: Yasmine Hines <[email protected]>
Drops the failure_info jsonb column from job_run. Nothing writes or reads it after #4843 and #4853, and the column was never populated in production outside the opt-in flag path anyway. Also drops the unused FailureInfo field from the queryapi sqlc model. Only merge after #4843 and #4853 have been deployed long enough that we are sure no consumer still depends on the column. Signed-off-by: Dejan Zele Pejchev <[email protected]> Signed-off-by: Yasmine Hines <[email protected]>
<!-- Thanks for sending a pull request! Here are some tips for you: --> #### What type of PR is this? #### What this PR does / why we need it Updating Lookout to include a hot/cold flag for utilizing the hot/cold partitioned jobs database, as well as updating the lookout pruner to only prune jobs from the `job_terminated` table when hot/cold is in use #### Which issue(s) this PR fixes <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_* --> Fixes # #### Special notes for your reviewer --------- Signed-off-by: David Slear <[email protected]> Signed-off-by: Yasmine Hines <[email protected]>
<!-- Thanks for sending a pull request! Here are some tips for you: --> #### What type of PR is this? feature / observability #### What this PR does / why we need it Adds a Prometheus counter metric to the lookout ingester to track job state updates processed by UpdateJobs(). The metric (`lookout_ingester_job_state_updates_total`) is labeled by state, allowing operators to observe transition rates and specifically monitor terminal state updates, which trigger cross-partition row movement in the Lookout database. Also fixes error categorization schema in `_local/executor` configs that was broken by a prior change. #### Special notes for your reviewer The `terminal_state_updates_total` counter was initially added as a standalone metric but was removed in favor of deriving it via PromQL from the per-state counter (sum by state where state is terminal). --------- Signed-off-by: Ian Hockett <[email protected]> Signed-off-by: Yasmine Hines <[email protected]>
Signed-off-by: Yasmine Hines <[email protected]>
7467ad3 to
60bc2e1
Compare
What type of PR is this?
Enhancement
What this PR does / why we need it
This PR give the button/tab for Job and Job Sets a distinct active state when one of them are selected. We need this to give a distinctive state of which tab is active.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer