added marlin gcode support and marlin fan pwm

[SamsonBox]

I tried to add marlin gcode support. I hope I did not forget any corner case. I also added the fan pwm support.

[arkypita]

Thank you for your code contribution. I see this commit make some modification to general code, so I need time to check it and evaluate impact on other feature. I'll do that asap.

[SamsonBox]

Hello arkypita,
I looked at the code changes again, and I had the idea to move the code which generated the spindel / laser gcodes to the GrblCore classes. Then there would be a centeral pice of code wich is responsible of than and a lot of duplicate code would be gone. If this would be OK for you, I will close the Request and sand a new one, when ist implemted.

[arkypita]

Ok for me! The right way to virtualize for a different controller is to put virtual function in GrblCore and override them in MarlinCore.

Please note that I am not able to test it with marlin, so be care of what you do!

Official LaserGRBL with MarlinCore is used around 300 users (less then 0.5% of lasergrbl users).
I don't know if it work on them, or what else (maybe they edit gcode by hand?) but it is important to not broke anything.
Maybe it is possible to clone a MarlinCore to a "MarlinCoreOld" so the old is keep for compatibility?

[SamsonBox]

Hello arkypita,
so I moved the generation of the spindle on / off code to the GrblCore an a marlin specific implementation to MarlinCore. I think the changes are now much better compare. So My problem is the other way round. I can cross check grbl changes. But the marlin gcode was not use able on my machine. I found a second tool which post processes the generated code to fit for marlin machines. But I think that should not be necessary. I think my changes are not bullet prof for all use cases (marlin / grbl / M3 / M4 / M5 / M106 / M107). But with the changes we have a good chance to get all the use cases together.

[SamsonBox]

@arkypita So I'm finished with my changes and rebased my branch. Can you review the code?

Thank you

[arkypita]

I am a little busy right now but I'll do it asap.

[SamsonBox]

Hi @arkypita I fixed another merlin bug. Would it be possible to merge this request in the near term? It's quiethard tomerg the generted designer files.

BR