Feat(eos_designs): Add support for mac-acls in network_ports/connected_endpoints#6290
Feat(eos_designs): Add support for mac-acls in network_ports/connected_endpoints#6290laxmikantchintakindi wants to merge 69 commits intoaristanetworks:develfrom
Conversation
github-actions
Bot
added
state: CI Updated
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6290
# Activate the virtual environment
source test-avd-pr-6290/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@feat/mac_acl#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,feat/mac_acl --force
# Optional: Install AVD examples
cd test-avd-pr-6290
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
for more information, see https://pre-commit.ci
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…pter_config.schema.yml Co-authored-by: Alexey Gorbunov <131046560+alexeygorbunov@users.noreply.github.com>
…pter_config.schema.yml Co-authored-by: Alexey Gorbunov <131046560+alexeygorbunov@users.noreply.github.com>
for more information, see https://pre-commit.ci
carlbuchmann
removed
the
one approval
|
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
….schema.yml Co-authored-by: Mahesh Kumar <122076792+MaheshGSLAB@users.noreply.github.com>
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
| raise AristaAvdInvalidInputsError(msg, host=self.shared_utils.hostname) | ||
|
|
||
| action += acl_entry.action | ||
| action = action + " " + acl_entry.source # pyright: ignore[reportOperatorIssue] |
There was a problem hiding this comment.
cant we fix the pyright issue, can you add the error message
There was a problem hiding this comment.
also if a user set remark along with missing source then we dont need this line. So all your below code should be when acl_entry.action is set
There was a problem hiding this comment.
It is already under else acl_entry.action
| action = "" | ||
| if acl_entry.remark: | ||
| action += f"remark {acl_entry.remark}" | ||
| elif acl_entry.action: |
There was a problem hiding this comment.
you should have one more else where none of them(remark, action) is set.
7 participants
Change Summary
Add support for
mac-acls_in/outin network_ports/connected_endpoints.These mac_acls can also be applied thorough port_profiles.
Created
mac_aclstop level key to list all the mac access lists required.Related Issue(s)
Fixes #5827
Component(s) name
arista.avd.eos_designsProposed changes
We span larger EVPN L2 networks accross a country and on the edge-ports sometimes Cisco devices running PVRST are connected. There is no need for us to forward the PVRST frames within our EVPN fabric, thus we would like to drop them on the ingress port already.
How to test
Checklist
User Checklist
Repository Checklist