Skip to content

fix: remove header & mirror routes so rollout can complete. Fixes #2526#4307

Open
chansuke wants to merge 3 commits intoargoproj:masterfrom
chansuke:fix/stuck-completing
Open

fix: remove header & mirror routes so rollout can complete. Fixes #2526#4307
chansuke wants to merge 3 commits intoargoproj:masterfrom
chansuke:fix/stuck-completing

Conversation

@chansuke
Copy link
Copy Markdown
Member

@chansuke chansuke commented Jun 5, 2025

Fixes #2526

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@chansuke chansuke force-pushed the fix/stuck-completing branch from 43c5297 to e0c760e Compare June 5, 2025 16:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

Published E2E Test Results

  4 files    4 suites   3h 54m 17s ⏱️
120 tests 103 ✅  7 💤 10 ❌
492 runs  453 ✅ 28 💤 11 ❌

For more details on these failures, see this check.

Results for commit bd8a772.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2025

Published Unit Test Results

2 456 tests   2 456 ✅  3m 20s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit bd8a772.

♻️ This comment has been updated with latest results.

@chansuke chansuke force-pushed the fix/stuck-completing branch from e0c760e to e21527a Compare June 8, 2025 08:41
@chansuke chansuke marked this pull request as ready for review June 8, 2025 10:43
@chansuke chansuke changed the title fix: stuck completing problem fix: remove header & mirror routes so rollout can complete. Fixes #2526 Jun 8, 2025
@chansuke chansuke force-pushed the fix/stuck-completing branch 2 times, most recently from 8b31d84 to e13885d Compare July 3, 2025 03:47
@zachaller zachaller self-assigned this Jul 7, 2025
@zachaller zachaller requested a review from Copilot July 7, 2025 23:02

This comment was marked as spam.

@chansuke chansuke force-pushed the fix/stuck-completing branch from 8d82fb8 to 4dd66db Compare July 9, 2025 15:34
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 9, 2025

@brianpham
Copy link
Copy Markdown

@zachaller Hello! I wanted to follow up to see if this is still planning to be merged.

@brianpham
Copy link
Copy Markdown

@Hariharasuthan99 Are you able to help to see if we can merge this PR?

@Hariharasuthan99
Copy link
Copy Markdown
Contributor

@chansuke , can you close&reopen or rebase the PR to make builds run again?

@chansuke
Copy link
Copy Markdown
Member Author

@Hariharasuthan99
ok!

@chansuke chansuke force-pushed the fix/stuck-completing branch from 4dd66db to bd8a772 Compare April 23, 2026 17:38
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 23, 2026

Codecov Report

❌ Patch coverage is 58.00000% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.90%. Comparing base (c40cb0d) to head (bd8a772).

Files with missing lines Patch % Lines
rollout/trafficrouting/istio/istio.go 58.00% 10 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4307      +/-   ##
==========================================
- Coverage   84.92%   84.90%   -0.03%     
==========================================
  Files         164      164              
  Lines       18966    18994      +28     
==========================================
+ Hits        16107    16126      +19     
- Misses       2002     2006       +4     
- Partials      857      862       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hariharasuthan99
Copy link
Copy Markdown
Contributor

@chansuke could you add/update test cases to increase coverage ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Argo Rollouts gets stuck completing rollout with canary-header and connected virtualservices

7 participants