fix: remove header & mirror routes so rollout can complete. Fixes #2526#4307
fix: remove header & mirror routes so rollout can complete. Fixes #2526#4307chansuke wants to merge 3 commits intoargoproj:masterfrom
Conversation
43c5297 to
e0c760e
Compare
Published E2E Test Results 4 files 4 suites 3h 54m 17s ⏱️ For more details on these failures, see this check. Results for commit bd8a772. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 456 tests 2 456 ✅ 3m 20s ⏱️ Results for commit bd8a772. ♻️ This comment has been updated with latest results. |
e0c760e to
e21527a
Compare
8b31d84 to
e13885d
Compare
8d82fb8 to
4dd66db
Compare
|
|
@zachaller Hello! I wanted to follow up to see if this is still planning to be merged. |
|
@Hariharasuthan99 Are you able to help to see if we can merge this PR? |
|
@chansuke , can you close&reopen or rebase the PR to make builds run again? |
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
Signed-off-by: chansuke <[email protected]>
4dd66db to
bd8a772
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4307 +/- ##
==========================================
- Coverage 84.92% 84.90% -0.03%
==========================================
Files 164 164
Lines 18966 18994 +28
==========================================
+ Hits 16107 16126 +19
- Misses 2002 2006 +4
- Partials 857 862 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@chansuke could you add/update test cases to increase coverage ? |



Fixes #2526
Checklist:
"fix(controller): Updates such and such. Fixes #1234".