fix(argocd-image-updater): Add ServiceMonitor TLS and authorization options#3874
Open
ystkfujii wants to merge 1 commit intoargoproj:mainfrom
Open
fix(argocd-image-updater): Add ServiceMonitor TLS and authorization options#3874ystkfujii wants to merge 1 commit intoargoproj:mainfrom
ystkfujii wants to merge 1 commit intoargoproj:mainfrom
Conversation
…ptions Signed-off-by: ystkfujii <ystk.fujii0731@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds optional ServiceMonitor settings for Argo CD Image Updater metrics scraping:
metrics.serviceMonitor.schememetrics.serviceMonitor.tlsConfigmetrics.serviceMonitor.authorizationThis is related to #3815, where the metrics endpoint is served over HTTPS on port
8443, but the generated ServiceMonitor currently does not allow configuring the scrape scheme or TLS settings.With this change, users can configure HTTPS metrics scraping, for example:
This PR intentionally does not change the default ServiceMonitor behavior. If scheme is not specified, Prometheus Operator defaults to HTTP. Changing the chart default to HTTPS would be a behavior change for existing users, and making insecureSkipVerify: true the default would not be a safe default.
This PR also uses authorization instead of bearerTokenFile, since bearerTokenFile is deprecated in the Prometheus Operator API.
Checklist: