Skip to content

fix(argocd-image-updater): Add ServiceMonitor TLS and authorization options#3874

Open
ystkfujii wants to merge 1 commit intoargoproj:mainfrom
ystkfujii:feat/add_schema_and_tlsconfig_to_servicemonitor
Open

fix(argocd-image-updater): Add ServiceMonitor TLS and authorization options#3874
ystkfujii wants to merge 1 commit intoargoproj:mainfrom
ystkfujii:feat/add_schema_and_tlsconfig_to_servicemonitor

Conversation

@ystkfujii
Copy link
Copy Markdown

@ystkfujii ystkfujii commented May 5, 2026

Summary

This PR adds optional ServiceMonitor settings for Argo CD Image Updater metrics scraping:

  • metrics.serviceMonitor.scheme
  • metrics.serviceMonitor.tlsConfig
  • metrics.serviceMonitor.authorization

This is related to #3815, where the metrics endpoint is served over HTTPS on port 8443, but the generated ServiceMonitor currently does not allow configuring the scrape scheme or TLS settings.

With this change, users can configure HTTPS metrics scraping, for example:

metrics:
  enabled: true
  serviceMonitor:
    enabled: true
    scheme: https
    tlsConfig:
      insecureSkipVerify: true

This PR intentionally does not change the default ServiceMonitor behavior. If scheme is not specified, Prometheus Operator defaults to HTTP. Changing the chart default to HTTPS would be a behavior change for existing users, and making insecureSkipVerify: true the default would not be a safe default.

This PR also uses authorization instead of bearerTokenFile, since bearerTokenFile is deprecated in the Prometheus Operator API.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

…ptions

Signed-off-by: ystkfujii <ystk.fujii0731@gmail.com>
@ystkfujii ystkfujii marked this pull request as draft May 5, 2026 13:53
@ystkfujii ystkfujii marked this pull request as ready for review May 5, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant