Skip to content

fix(argo-workflows): Updating argo-workflow CM generation to allow disabling built-in prometheus exporter #3865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rurod wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(argo-workflows): Updating argo-workflow CM generation to allow disabling built-in prometheus exporter #3865

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9112bfb
Updating argo-workflow CM generation to allow disabling built-in prom…
rurod Apr 29, 2026
df3556b
Remove blankline from Chart.yaml
rurod Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/argo-workflows/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ appVersion: v4.0.5
name: argo-workflows
description: A Helm chart for Argo Workflows
type: application
version: 1.0.13
version: 1.0.14
icon: https://argo-workflows.readthedocs.io/en/stable/assets/logo.png
home: https://github.com/argoproj/argo-helm
sources:
Expand All @@ -16,5 +16,5 @@ annotations:
fingerprint: 2B8F22F57260EFA67BE1C5824B11F800CD9D2252
url: https://argoproj.github.io/argo-helm/pgp_keys.asc
artifacthub.io/changes: |
- kind: changed
description: Use Recreate deployment strategy when controller replicas is 1 to prevent two controllers running during rollout
- kind: fixed
description: Fix controller configmap generation so it disable argo-workflow built-in prometheus exporter when metricsConfig is set to false
20 changes: 10 additions & 10 deletions charts/argo-workflows/templates/controller/workflow-controller-config-map.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,17 @@ data:
{{- toYaml .Values.customArtifactRepository | nindent 6 }}
{{- end }}
{{- end }}
{{- if .Values.controller.metricsConfig.enabled }}
{{- with .Values.controller.metricsConfig }}
Copy link
Copy Markdown
Collaborator

@vladlosev vladlosev May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

controller.metricsConfig is provided in the default chart values, so this condition will always be true.

metricsConfig:
enabled: {{ .Values.controller.metricsConfig.enabled }}
path: {{ .Values.controller.metricsConfig.path }}
port: {{ .Values.controller.metricsConfig.port }}
{{- if .Values.controller.metricsConfig.metricsTTL }}
metricsTTL: {{ .Values.controller.metricsConfig.metricsTTL }}
{{- end }}
ignoreErrors: {{ .Values.controller.metricsConfig.ignoreErrors }}
secure: {{ .Values.controller.metricsConfig.secure }}
{{- with .Values.controller.metricsConfig.modifiers }}
enabled: {{ .enabled }}
path: {{ .path }}
port: {{ .port }}
{{- if .metricsTTL }}
metricsTTL: {{ .metricsTTL }}
{{- end }}
ignoreErrors: {{ .ignoreErrors }}
secure: {{ .secure }}
{{- with .modifiers }}
modifiers:
{{- toYaml . | nindent 8 }}
{{- end }}
Expand Down