Skip to content

feat(argo-cd): add additional annotation support for redis-secret-init RBAC resources#3823

Open
magraef wants to merge 4 commits intoargoproj:mainfrom
magraef:feature/redis-secret-init-additional-annotations
Open

feat(argo-cd): add additional annotation support for redis-secret-init RBAC resources#3823
magraef wants to merge 4 commits intoargoproj:mainfrom
magraef:feature/redis-secret-init-additional-annotations

Conversation

@magraef
Copy link
Copy Markdown

@magraef magraef commented Apr 7, 2026

When using Argo CD to manage the argo-cd helm chart, the redis-secret-init job and its associated RBAC resources (Role, RoleBinding, ServiceAccount) are managed as Helm hooks.

The current default helm.sh/hook-delete-policy: before-hook-creation can lead to timing issues. Specifically, Argocd is running is managing itself in Argocd this results in stuck in waiting for completion of hook batch/Job/argocd-redis-secret-init from #2887.

I have added support for adding additional annotations on the Role and RoleBinding resources for redis-secret-init. This allows users to overwrite the default hook delete policy with argocd.argoproj.io/hook-delete-policy: HookSucceeded (or other values), ensuring that the RBAC resources persist until the job has successfully completed and let argocd manage itself successfully.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

Comment thread charts/argo-cd/Chart.yaml Outdated
artifacthub.io/changes: |
- kind: added
description: Add additional annotations support for redis-secret-init Role and RoleBinding
- kind: changed
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the old line.

@mbevc1 mbevc1 enabled auto-merge (squash) April 29, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants