feat(argo-cd): add additional annotation support for redis-secret-init RBAC resources#3823
Open
magraef wants to merge 4 commits intoargoproj:mainfrom
Open
Conversation
…Binding Signed-off-by: magraef <[email protected]>
Signed-off-by: magraef <[email protected]>
tico24
reviewed
Apr 21, 2026
| artifacthub.io/changes: | | ||
| - kind: added | ||
| description: Add additional annotations support for redis-secret-init Role and RoleBinding | ||
| - kind: changed |
…ions Signed-off-by: Marco Maurer (-Kilchhofer) <[email protected]>
mkilchhofer
approved these changes
Apr 29, 2026
mbevc1
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using Argo CD to manage the argo-cd helm chart, the redis-secret-init job and its associated RBAC resources (Role, RoleBinding, ServiceAccount) are managed as Helm hooks.
The current default helm.sh/hook-delete-policy: before-hook-creation can lead to timing issues. Specifically, Argocd is running is managing itself in Argocd this results in stuck in waiting for completion of hook batch/Job/argocd-redis-secret-init from #2887.
I have added support for adding additional annotations on the Role and RoleBinding resources for redis-secret-init. This allows users to overwrite the default hook delete policy with argocd.argoproj.io/hook-delete-policy: HookSucceeded (or other values), ensuring that the RBAC resources persist until the job has successfully completed and let argocd manage itself successfully.
Checklist: