Skip to content

feat(github): Linter to check that the changelog was replaced, not appended#3791

Merged
tico24 merged 6 commits intomainfrom
changelog-linter
Mar 22, 2026
Merged

feat(github): Linter to check that the changelog was replaced, not appended#3791
tico24 merged 6 commits intomainfrom
changelog-linter

Conversation

@tico24
Copy link
Copy Markdown
Member

@tico24 tico24 commented Mar 19, 2026

Hopefully means that reviewers have to comment less when people duplicate up the changelog.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

@tico24 tico24 self-assigned this Mar 19, 2026
@tico24 tico24 changed the title feat(ci): Linter to check that the changelog was replaced, not appended feat(github): Linter to check that the changelog was replaced, not appended Mar 19, 2026
@tico24 tico24 marked this pull request as ready for review March 19, 2026 14:10
jmeridth
jmeridth previously approved these changes Mar 19, 2026
@tico24 tico24 enabled auto-merge (squash) March 19, 2026 14:12
Copy link
Copy Markdown
Member

@mkilchhofer mkilchhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest is perfect, but we cannot run bash in pull_request_target runs.

https://www.stepsecurity.io/blog/hackerbot-claw-github-actions-exploitation

Comment thread .github/workflows/lint-changelog.yml Outdated
@jmeridth
Copy link
Copy Markdown
Member

Rest is perfect, but we cannot run bash in pull_request_target runs.

https://www.stepsecurity.io/blog/hackerbot-claw-github-actions-exploitation

#3792 😄

Comment thread .github/workflows/lint-changelog.yml Outdated
Signed-off-by: Tim Collins <[email protected]>
@tico24 tico24 requested a review from jmeridth March 20, 2026 11:20
@tico24 tico24 merged commit 730c13f into main Mar 22, 2026
6 checks passed
@tico24 tico24 deleted the changelog-linter branch March 22, 2026 23:39
xavier-re pushed a commit to xavier-re/argo-helm-xr that referenced this pull request Apr 8, 2026
…pended (argoproj#3791)

feat(ci): Linter to check that the changelog was replaced, not appended

Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Xavier Renaut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants