Skip to content

feat(argo-events): Script to update the Argo Events CRDs#3784

Merged
tico24 merged 6 commits intomainfrom
argo-events-script
Mar 18, 2026
Merged

feat(argo-events): Script to update the Argo Events CRDs#3784
tico24 merged 6 commits intomainfrom
argo-events-script

Conversation

@tico24
Copy link
Copy Markdown
Member

@tico24 tico24 commented Mar 17, 2026

A script similar to the argo-workflows/image-updater ones to go and grab the upstream CRDs based on the version applied to it.

Renames the CRDs to match upstream (hence the chart bump) but the contents are the same.

Script runs when renovate bumps ther version

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

@tico24 tico24 self-assigned this Mar 17, 2026
@tico24 tico24 marked this pull request as ready for review March 17, 2026 07:57
yu-croco
yu-croco previously approved these changes Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 👏

jmeridth
jmeridth previously approved these changes Mar 18, 2026
@tico24 tico24 dismissed stale reviews from jmeridth and yu-croco via 9372e8d March 18, 2026 10:43
jmeridth
jmeridth previously approved these changes Mar 18, 2026
@tico24 tico24 requested a review from yu-croco March 18, 2026 11:39
@tico24 tico24 enabled auto-merge (squash) March 18, 2026 11:42
@jmeridth jmeridth requested a review from mbevc1 March 18, 2026 14:57
mbevc1
mbevc1 previously approved these changes Mar 18, 2026
@tico24 tico24 dismissed stale reviews from mbevc1 and jmeridth via bd72eaf March 18, 2026 15:22
@tico24 tico24 requested review from jmeridth and mbevc1 March 18, 2026 15:24
@tico24
Copy link
Copy Markdown
Member Author

tico24 commented Mar 18, 2026

I love github.

Copy link
Copy Markdown
Member

@jmeridth jmeridth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I have to approve this one...more...time 😉

@tico24 tico24 merged commit 192e332 into main Mar 18, 2026
6 checks passed
@tico24 tico24 deleted the argo-events-script branch March 18, 2026 16:47
@mbevc1
Copy link
Copy Markdown
Collaborator

mbevc1 commented Mar 18, 2026

Hit me one more time 🎶 😄

xavier-re pushed a commit to xavier-re/argo-helm-xr that referenced this pull request Apr 8, 2026
Signed-off-by: Tim Collins <[email protected]>
Signed-off-by: Tim Collins <[email protected]>
Co-authored-by: Aikawa <[email protected]>
Signed-off-by: Xavier Renaut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants