Skip to content

feat(argo-cd): Allow configuring external redis endpoint from secret#3734

Draft
jdcmarques wants to merge 2 commits intoargoproj:mainfrom
jdcmarques:feat-allow-extenal-redis-server
Draft

feat(argo-cd): Allow configuring external redis endpoint from secret#3734
jdcmarques wants to merge 2 commits intoargoproj:mainfrom
jdcmarques:feat-allow-extenal-redis-server

Conversation

@jdcmarques
Copy link
Copy Markdown

@jdcmarques jdcmarques commented Feb 17, 2026

Description:
We are using Argo CD with AWS Elasticache, our Elasticache is provisioned via crossplane alongside the chart.
To be able to correctly point Argo we need to do two installs, or have Elasticache created separately because of the endpoint.
With this change we allow the redis endpoint when using externalRedis to be passed from the secret, it will be up to the user to ensure it is in host:port format

Fixes #3735

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • I have created a separate pull request for each chart according to pull requests
  • My build is green (troubleshooting builds).

@jdcmarques jdcmarques force-pushed the feat-allow-extenal-redis-server branch from f391f63 to af06b6f Compare February 17, 2026 21:57
@jdcmarques jdcmarques changed the title feat(argo-cd): Allow external redis server from secret feat(argo-cd): Allow configuring external redis endpoint from secret Feb 17, 2026
@jdcmarques jdcmarques marked this pull request as ready for review February 17, 2026 22:05
@jdcmarques jdcmarques force-pushed the feat-allow-extenal-redis-server branch from f4be196 to f83df02 Compare February 27, 2026 13:20
@github-actions
Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mkilchhofer mkilchhofer added on-hold Issues or Pull Requests with this label will never be considered stale and removed no-pr-activity labels Apr 29, 2026
@mkilchhofer
Copy link
Copy Markdown
Member

mkilchhofer commented Apr 29, 2026

Sorry for the late reply. Maybe it would make sense to refactor the externalRedis.existingSecret-feature completely with a structure like this:

externalRedis:

  # ..

  existingSecret:
    name: "asdf"
    serverKey: "xyz"
    usernameKey: "abc"
    passwordKey: "foobar"

Hopefully this would solve other feature requests more easily like this one over there:

For sure we'd need to bump the major version of the chart, but that's fully okay for me.

What do you think, @jdcmarques ?

@mkilchhofer mkilchhofer marked this pull request as draft April 29, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

argo-cd on-hold Issues or Pull Requests with this label will never be considered stale size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

argo-cd: Allow External Redis endpoint from secret

2 participants