feat(argo-cd): adding httproute support to applicationset controller's webhook feature#3672
feat(argo-cd): adding httproute support to applicationset controller's webhook feature#3672skluther wants to merge 1 commit intoargoproj:mainfrom
Conversation
skluther
requested review from
jmeridth,
mbevc1,
mkilchhofer,
pdrastil,
tico24 and
yu-croco
as code owners
skluther
force-pushed
the
feat/argo-cd-applicationset-httproute
branch
from
b5887ae to
22ca221
Compare
skluther
force-pushed
the
feat/argo-cd-applicationset-httproute
branch
from
22ca221 to
214eb62
Compare
…s webhook support Signed-off-by: Stephen Kluthe <[email protected]>
skluther
force-pushed
the
feat/argo-cd-applicationset-httproute
branch
from
214eb62 to
251fc87
Compare
|
@tico24 would I be able to get an approval for the workflow that requires it? Just want to make sure I'm still paying attention if there are changes that come up. |
| @@ -28,3 +28,5 @@ annotations: | |||
| artifacthub.io/changes: | | |||
| - kind: changed | |||
There was a problem hiding this comment.
Please remove the old change. Keep only your change.
| backendRefs: | ||
| - group: '' | ||
| kind: Service | ||
| name: {{ include "argo-cd.applicationSet.fullname" . }} |
There was a problem hiding this comment.
Use the $fullName variable
| apiVersion: gateway.networking.k8s.io/v1 | ||
| kind: HTTPRoute | ||
| metadata: | ||
| name: {{ include "argo-cd.applicationSet.fullname" . }} |
There was a problem hiding this comment.
Use the $fullName variable
|
Sorry this pull request stays unchanged more than one month @skluther if you have not enough time to update it. I can do it if you prefer. |
|
I can take a look at it tomorrow, sorry, I don’t have notifications on so I missed the review. |
Hi @skluther! Appreciating your engagement :) Any idea when you will continue? I would like to get rid of another workaround ;) |
|
Hi, |
4 participants
Adds gateway api support for the applicationset controller webhook endpoint.
Changes:
.server.with.applicationSet.Please let me know if you need anything changed.
Also, for the bottom item of the checklist do I just leave that unchecked until the check action is approved?
Checklist: