Add error message to Nelder-Mead optimizer when user cost function returns NaN value#635
Open
henrygerardmoore wants to merge 2 commits intoargmin-rs:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 91.72% 91.68% -0.04%
==========================================
Files 177 177
Lines 20840 20849 +9
==========================================
Hits 19116 19116
- Misses 1724 1733 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I just had a bug in my cost function where it returned NaN and got the unreachable point error in the Nelder-Mead optimizer. Of course this is my fault 😁 but I thought it'd be nice to have an error message directly stating this since it's the only case I can think of that should hit that unreachable point message so that a user that makes my same mistake in the future can see exactly why they got it without debugging.