Merged
Conversation
|
✔️ All good! |
lipskis
force-pushed
the
dynamic-span-kind
branch
from
447b973 to
d0e93f0
Compare
Refactor Appsignal::instrument to use named arguments with specific
types. Allow setting span kind and attributes as optional arguments.
```php
$serverSpan = Appsignal::instrument('some_event', spanKind:
SpanKind::KIND_SERVER);
```
This change requires passing a closure as a named argument if any
optional arguments are skipped.
```php
Appsignal::instrument("some_event", closure: fn() => sleep(1));
```
lipskis
force-pushed
the
dynamic-span-kind
branch
from
d0e93f0 to
68383a2
Compare
lipskis
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor Appsignal::instrument to use named arguments with specific types. Allow setting span kind and attributes as optional arguments.
This change requires passing a closure as a named argument if any optional arguments are skipped.
[skip review]