Add proper entity query support#794
Draft
mxr576 wants to merge 3 commits intoapigee:2.xfrom
Draft
Conversation
0697d17 to
cb4b363
Compare
074daad to
7895d96
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #794 +/- ##
=========================================
Coverage 43.91% 43.91%
Complexity 3021 3021
=========================================
Files 342 342
Lines 11114 11114
=========================================
Hits 4881 4881
Misses 6233 6233
|
Contributor
Author
|
If somebody could RTBC this on Drupal.org, that might speed up the merge of this fix |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Contributor
|
@mxr576 , @shishir-intelli will validate and respond on drupal.org ticket. |
Collaborator
@mxr576 Done |
Contributor
Author
|
The fix was merged, waiting for a tagged release: https://www.drupal.org/project/entity/issues/3332956 |
Contributor
Author
Contributor
Author
|
https://www.drupal.org/project/entity/releases/8.x-1.5 is out for a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up on #790 which aim was hot fixing only. The scope of this PR is finalizing the task by adding similar level of entity query support as content entity types have in Drupal core.
Remaining tasks:
PS.: