Fix TeamAppAccessHandler::checkCreateAccess() to respect $context array#1267
Open
davidbondor12 wants to merge 2 commits intoapigee:4.xfrom
Open
Fix TeamAppAccessHandler::checkCreateAccess() to respect $context array#1267davidbondor12 wants to merge 2 commits intoapigee:4.xfrom
davidbondor12 wants to merge 2 commits intoapigee:4.xfrom
Conversation
…ay (apigee#1266) When checking Team App creation access programmatically via the entity access control handler (e.g., `$access_handler->createAccess('team_app', $user, ['team' => $team])`), the check was incorrectly returning neutral/false. This occurred because `checkCreateAccess()` ignored the provided `$context` array and strictly relied on the current URL route containing a `{team}` parameter. This breaks access checks for headless architectures, custom REST/JSON:API endpoints, and any custom module that does not use standard Drupal UI routes. This commit updates `TeamAppAccessHandler::checkCreateAccess()` to first attempt extracting the team from `$context['team']`, and only falls back to the route match parameter if the context is empty. It also includes logic to upcast string IDs to Team entities when passed via context.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.x #1267 +/- ##
============================================
- Coverage 43.53% 42.35% -1.19%
Complexity 3119 3119
============================================
Files 345 345
Lines 11392 11386 -6
============================================
- Hits 4959 4822 -137
- Misses 6433 6564 +131
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking Team App creation access programmatically via the entity access control handler (e.g.,
$access_handler->createAccess('team_app', $user, ['team' => $team])), the check was incorrectly returning neutral/false. This occurred becausecheckCreateAccess()ignored the provided$contextarray and strictly relied on the current URL route containing a{team}parameter.This breaks access checks for headless architectures, custom REST/JSON:API endpoints, and any custom module that does not use standard Drupal UI routes.
This commit updates
TeamAppAccessHandler::checkCreateAccess()to first attempt extracting the team from$context['team'], and only falls back to the route match parameter if the context is empty. It also includes logic to upcast string IDs to Team entities when passed via context.