feat(docker): add environment-based debugger control#40327
Conversation
Add SUPERSET_DEBUG_ENABLED environment variable to control Werkzeug debugger in development Docker containers. Debugger is disabled by default and only enabled when explicitly requested. Security benefits: - Defense-in-depth: debugger disabled by default in Docker - Maintains functionality: developers can enable when needed - Clear visibility: startup messages show debugger status - PIN protection: modern Werkzeug includes PIN protection Usage: - Default: debugger disabled (secure) - SUPERSET_DEBUG_ENABLED=true: debugger enabled with PIN protection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code Review Agent Run #13d0dfActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help |
|
The PR diff shows a change to the docker/docker-bootstrap.sh |
…tation - Fix critical issue where FLASK_DEBUG=true overrode debugger control - Use --no-debugger explicitly when SUPERSET_DEBUG_ENABLED != true - Add security warnings to PyPI installation docs - Document SUPERSET_DEBUG_ENABLED environment variable - Address Codeant security review findings Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary
Adds environment variable control for the Werkzeug debugger in Docker development containers to address security concerns with the exposed
/consoleendpoint.Security Context
While modern Werkzeug includes PIN protection for the debugger console, the PIN can be calculated deterministically in Docker environments using known container defaults combined with readable system files. This change implements defense-in-depth by disabling the debugger by default.
Changes
SUPERSET_DEBUG_ENABLEDenvironment variable checkUsage
Default behavior (secure):
docker compose up app # Shows: "🔒 Werkzeug debugger disabled"Enable debugging when needed:
SUPERSET_DEBUG_ENABLED=true docker compose up app # Shows: "⚠️ Werkzeug debugger enabled"Testing Instructions
SUPERSET_DEBUG_ENABLED=true- verify debugger enabled message🤖 Generated with Claude Code