feat(mcp): add list_tags and get_tag_info MCP tools#40300
Draft
aminghadersohi wants to merge 2 commits into
Draft
feat(mcp): add list_tags and get_tag_info MCP tools#40300aminghadersohi wants to merge 2 commits into
aminghadersohi wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #40300 +/- ##
==========================================
- Coverage 64.14% 64.14% -0.01%
==========================================
Files 2592 2596 +4
Lines 138841 138993 +152
Branches 32201 32209 +8
==========================================
+ Hits 89064 89160 +96
- Misses 48245 48300 +55
- Partials 1532 1533 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdab1aa to
cc7978c
Compare
Adds list_tags and get_tag_info MCP tools in a new superset/mcp_service/tag/ domain, following the existing database/dataset/dashboard patterns. Registers both tools in app.py and covers them with unit tests. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…upport
TagFilter documents 'ct' as a valid operator but ColumnOperatorEnum was
missing it, causing ValidationError when constructing TagFilter with opr="ct".
Added ct = "ct" with ilike("%val%") mapping, updated TYPE_OPERATOR_MAP for
string columns, and updated base_dao_test to cover the new operator.
cc7978c to
ba361ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds
list_tagsandget_tag_infoMCP tools in a newsuperset/mcp_service/tag/domain, following the established pattern used by the database, dataset, and dashboard domains.New files:
superset/mcp_service/tag/__init__.pysuperset/mcp_service/tag/schemas.py—TagFilter,TagInfo,TagList,ListTagsRequest,GetTagInfoRequest,TagError,serialize_tag_object()superset/mcp_service/tag/tool/list_tags.py— list tags with filtering, search, paginationsuperset/mcp_service/tag/tool/get_tag_info.py— get a single tag by numeric IDtests/unit_tests/mcp_service/tag/tool/test_tag_tools.py— unit tests covering basic listing, search, filters, empty results, error handling, not-found, and type serializationBoth tools are registered in
app.py.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A — MCP tool additions only.
TESTING INSTRUCTIONS
list_tagsandget_tag_infoappear in the tool list.list_tagswith no arguments — should return the first page of tags.get_tag_infowith a valid tag ID — should return tag name, type, and description.ADDITIONAL INFORMATION