Fix resource leaks: use try-with-resources and add cleanup hooks #1930
Merged
Conversation
- RegexURLFilterBase: use try-with-resources for classpath InputStream; add null check when resource file is not found in classpath - DebugParseFilter: add cleanup() override to close OutputStream; add SLF4J logger and replace e.printStackTrace() - HttpProtocol (Playwright): add finally block to ensure tracing is always stopped even when an exception is thrown
rzo1
approved these changes
Jun 4, 2026
jnioche
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several resources were not properly closed, leading to potential leaks in
long-running crawl topologies.
RegexURLFilterBase: use try-with-resources for the classpathInputStream; add a null check when the resource file is not foundDebugParseFilter: addcleanup()override to close the output stream;add a proper SLF4J logger (replacing
e.printStackTrace())HttpProtocol(Playwright): wrap the page navigation block in atry/finally to ensure tracing is always stopped even when an exception
is thrown, preventing a tracing resource leak