SOLR-15111 Use JDK8 Base64 instead of own implementation#24
Merged
janhoy merged 2 commits intoapache:mainfrom Aug 31, 2021
Merged
SOLR-15111 Use JDK8 Base64 instead of own implementation#24janhoy merged 2 commits intoapache:mainfrom
janhoy merged 2 commits intoapache:mainfrom
Conversation
janhoy
approved these changes
Mar 24, 2021
solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Rebased on top of the current main. @janhoy can you please take a look at it. |
janhoy
approved these changes
Aug 26, 2021
Contributor
janhoy
left a comment
There was a problem hiding this comment.
I have no further comments. If tests pass I’m happy :)
Contributor
|
Please add a CHANGES.txt entry for version 8.10, and I’ll commit. Have you run the entire test suite? |
Contributor
Author
|
@janhoy Added the CHANGES.txt entry. I executed |
epugh
referenced
this pull request
in epugh/solr
Oct 22, 2021
Co-authored-by: Jan Høydahl <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original lucene-solr pull request: apache/lucene-solr#2252 I removed the lucene part of it.
Description
JDK8 has a builtin Base64 encoder and decoder, there is no need to use own implementation for this.
Solution
Eliminate own implementation.
Tests
Unit tests
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.