MINOR: Move inter-broker NetworkClient factory to server module#22346
Open
JiayaoS wants to merge 2 commits into
Open
MINOR: Move inter-broker NetworkClient factory to server module#22346JiayaoS wants to merge 2 commits into
JiayaoS wants to merge 2 commits into
Conversation
github-actions
Bot
added
triage
| import org.apache.kafka.server.util.timer.{SystemTimer, SystemTimerReaper, Timer} | ||
| import org.apache.kafka.server.util.{Deadline, FutureUtils, KafkaScheduler, NetworkPartitionMetadataClient, PartitionMetadataClient} | ||
| import org.apache.kafka.server.{AssignmentsManager, AutoTopicCreationManager, BrokerFeatures, BrokerLifecycleManager, ClientMetricsManager, DefaultApiVersionManager, DefaultAutoTopicCreationManager, DelayedActionQueue, FetchManager, FetchSessionCacheShard, KRaftTopicCreator, NodeToControllerChannelManagerImpl, ProcessRole, RaftControllerNodeProvider} | ||
| import org.apache.kafka.server.{AssignmentsManager, AutoTopicCreationManager, BrokerFeatures, BrokerLifecycleManager, ClientMetricsManager, DefaultApiVersionManager, DefaultAutoTopicCreationManager, DelayedActionQueue, FetchManager, FetchSessionCacheShard, KRaftTopicCreator, InterBrokerNetworkClientFactory, NodeToControllerChannelManagerImpl, ProcessRole, RaftControllerNodeProvider} |
Contributor
There was a problem hiding this comment.
Suggested change
| import org.apache.kafka.server.{AssignmentsManager, AutoTopicCreationManager, BrokerFeatures, BrokerLifecycleManager, ClientMetricsManager, DefaultApiVersionManager, DefaultAutoTopicCreationManager, DelayedActionQueue, FetchManager, FetchSessionCacheShard, KRaftTopicCreator, InterBrokerNetworkClientFactory, NodeToControllerChannelManagerImpl, ProcessRole, RaftControllerNodeProvider} | |
| import org.apache.kafka.server.{AssignmentsManager, AutoTopicCreationManager, BrokerFeatures, BrokerLifecycleManager, ClientMetricsManager, DefaultApiVersionManager, DefaultAutoTopicCreationManager, DelayedActionQueue, FetchManager, FetchSessionCacheShard, InterBrokerNetworkClientFactory, KRaftTopicCreator,, NodeToControllerChannelManagerImpl, ProcessRole, RaftControllerNodeProvider} |
Contributor
There was a problem hiding this comment.
looking at the alphabetic order
| private InterBrokerNetworkClientFactory() {} | ||
|
|
||
| public static NetworkClient create(String prefix, | ||
| AbstractKafkaConfig config, |
Contributor
There was a problem hiding this comment.
I think the params are not indented here well.
m1a2st
reviewed
May 25, 2026
Collaborator
m1a2st
left a comment
m1a2st
left a comment
There was a problem hiding this comment.
Please merge trunk to fix build error, Thanks
JiayaoS
force-pushed
the
feature/NetworkUtils
branch
from
d0b3105 to
8d88531
Compare
Contributor
Author
Thanks, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the inter-broker NetworkClient factory from core to the server module and make it depend on AbstractKafkaConfig instead of KafkaConfig.
Move saslMechanismInterBrokerProtocol to AbstractKafkaConfig to keep the factory independent of KafkaConfig.