Skip to content

Fix operator tests for transient null TsBlocks#17838

Merged
JackieTien97 merged 8 commits into
masterfrom
fix-offset-operator-test-null-tsblock
Jun 4, 2026
Merged

Fix operator tests for transient null TsBlocks#17838
JackieTien97 merged 8 commits into
masterfrom
fix-offset-operator-test-null-tsblock

Conversation

@Caideyipi
Copy link
Copy Markdown
Collaborator

@Caideyipi Caideyipi commented Jun 3, 2026

Summary

  • add OperatorTestUtils.nextNonNull / lastNonNull for test-only consumption of operators whose next() may return transient null
  • update Offset, series scan/aggregation, fill, concat, into, merge-sort, and last-cache operator tests to use the helper instead of directly dereferencing next() results
  • keep tests that intentionally assert null or already validate null positions unchanged

Tests

  • git diff --check
  • mvn -pl iotdb-core/datanode spotless:check -Ddevelocity.off=true -DskipTests
  • Not run to completion locally: targeted datanode JUnit commands fail before selected tests because this workspace cannot currently compile/testCompile datanode cleanly without a complete main reactor output

@Caideyipi Caideyipi changed the title Fix OffsetOperatorTest null TsBlock handling Fix operator tests for transient null TsBlocks Jun 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.79%. Comparing base (66d0c07) to head (02f5bc3).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17838      +/-   ##
============================================
- Coverage     40.98%   40.79%   -0.20%     
- Complexity     2611     2613       +2     
============================================
  Files          5188     5200      +12     
  Lines        351973   353687    +1714     
  Branches      45071    45252     +181     
============================================
+ Hits         144272   144292      +20     
- Misses       207701   209395    +1694     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 4, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
10.8% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@JackieTien97 JackieTien97 merged commit 16d3669 into master Jun 4, 2026
39 of 44 checks passed
@JackieTien97 JackieTien97 deleted the fix-offset-operator-test-null-tsblock branch June 4, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants