test: cover regexp_like multiline flag#22284
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
sqllogictest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
regexp_likeshould honor PostgreSQL multiline flagm#22268.Rationale for this change
The issue documents a PostgreSQL compatibility expectation for
regexp_like(E'a\nb', '^b', 'm'): with the multiline flag,^should match after a newline. Currentmainalready returns the expected result for the reported SQL, so this PR adds focused regression coverage to keep that behavior from drifting.What changes are included in this PR?
This adds
regexp_liketests for the multilinemflag in the SQL logic test suite and in the Rust unit tests for the scalar, array/scalar, and array/array execution paths. The adjacent no-flags SQL case remains false, documenting that the new behavior is specifically tied tom.Are these changes tested?
Yes:
cargo fmt --all --checkgit diff --checkcargo test -p datafusion-functions --lib regexp_likecargo test -p datafusion-sqllogictest --test sqllogictests -- regexp_likeAre there any user-facing changes?
No. This is regression coverage for existing behavior.