Correction in the public IP ranges addition form for the Public traffic type#13356
Open
gruckbit wants to merge 1 commit into
Open
Correction in the public IP ranges addition form for the Public traffic type#13356gruckbit wants to merge 1 commit into
gruckbit wants to merge 1 commit into
Conversation
Member
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13356 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
- Complexity 13434 13435 +1
============================================
Files 5666 5666
Lines 500645 500648 +3
Branches 60801 60801
============================================
- Hits 81426 81425 -1
- Misses 410112 410115 +3
- Partials 9107 9108 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ACS UI currently has an inconsistency in the public IP ranges addition form for the Public traffic type of zones. When the
Set reservationswitch is toggled on and off and the form is submitted, the Domain and Account fields are not reset to their initial values. Therefore, modifications have been applied to fix this inconsistency.Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
Before:
After:
How Has This Been Tested?
First, I created a domain. Next, I added a public IP range with the
Set reservationswitch selected and its fields filled with a domain and/or account. Before submitting the form, I disabled the toggle. After, I verified that the account and domain are reset to their initial values.