Skip to content

Remove redundant HTTP->HTTPS redirect in .htaccess#38522

Open
liferoad wants to merge 1 commit into
apache:masterfrom
liferoad:fix/remove-redundant-https-redirect
Open

Remove redundant HTTP->HTTPS redirect in .htaccess#38522
liferoad wants to merge 1 commit into
apache:masterfrom
liferoad:fix/remove-redundant-https-redirect

Conversation

@liferoad
Copy link
Copy Markdown
Contributor

Summary

Removes redundant HTTP->HTTPS redirect rules in website/www/site/static/.htaccess that are already handled by Apache TLP infrastructure.

Changes

  • Removed lines 3-15 containing the HTTP->HTTPS RewriteCond and RewriteRule directives

Test plan

  • Verified the remaining redirects and rules are intact
  • No functional changes to other redirects or CSP configuration

Fixes #37432

The HTTP->HTTPS redirect is already handled by Apache TLP infrastructure,
so the redirect rules in website/www/site/static/.htaccess are redundant.

Fixes apache#37432
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the website configuration by removing manual redirect directives that are no longer necessary. By relying on the existing Apache TLP infrastructure to manage HTTP to HTTPS transitions, the codebase becomes cleaner and easier to maintain without impacting site functionality.

Highlights

  • Configuration Cleanup: Removed redundant HTTP to HTTPS redirect rules from the .htaccess file.
  • Infrastructure Alignment: Delegated redirect management to the Apache TLP infrastructure, which now handles these requests automatically.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the HTTP to HTTPS permanent redirect rules and associated comments from the .htaccess file for beam.apache.org. I have no feedback to provide as there were no review comments to evaluate.

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There should be no need to redirect to https, as that is done by the TLP server

1 participant