Skip to content

fix(test): avoid race condition in TwoBrokerVirtualTopicSelectorAwareForwardingTest #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbonofre wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −4
Open

fix(test): avoid race condition in TwoBrokerVirtualTopicSelectorAwareForwardingTest #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...t/java/org/apache/activemq/usecases/TwoBrokerVirtualTopicSelectorAwareForwardingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,10 +520,11 @@ public void testSelectorAwareForwarding() throws Exception {
assertEquals(2, msgsB.getMessageCount());


// queue should be drained
assertEquals(0, brokerB.getDestination(new ActiveMQQueue("Consumer.B.VirtualTopic.tempTopic"))
.getDestinationStatistics().getMessages().getCount());
// and the enqueue count for the remote queue should only be 1
// queue should be drained - use Wait.waitFor to allow broker ACK processing to complete
assertTrue("queue should be drained after consumer ACKs", Wait.waitFor(() ->
brokerB.getDestination(new ActiveMQQueue("Consumer.B.VirtualTopic.tempTopic"))
.getDestinationStatistics().getMessages().getCount() == 0, 5000, 100));
// and the enqueue count for the remote queue should only be 3
assertEquals(3, brokerB.getDestination(new ActiveMQQueue("Consumer.B.VirtualTopic.tempTopic"))
.getDestinationStatistics().getEnqueues().getCount());

Expand Down