refactor: remove extension packages, only keep x6#4715
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @GaoFuhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on a significant refactoring of the project's directory structure. It involves relocating the x6-devtool package from its standalone packages/x6-devtool directory into the packages/x6-extensions directory, specifically under packages/x6-extensions/x6-devtool. This change aims to consolidate related packages under a more logical grouping, improving overall project organization and maintainability.
Highlights
- Project Structure Refactoring: The
x6-devtoolpackage has been moved frompackages/x6-devtooltopackages/x6-extensions/x6-devtool. This consolidates the devtool package within thex6-extensionsnamespace, aligning with a broader organizational strategy for the project's packages.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
你好,这次 PR 主要将 x6-devtool 包迁移到了 x6-extensions 目录下,这是一次不错的重构。代码本身没有改动,但我对迁移后的文件做了一些检查,并发现了一些可以改进的地方,主要集中在 DevTools 脚本和 React 组件中。
具体来说,我发现了一些问题,包括:
- 一个函数名中的拼写错误。
- 在 Chrome 扩展的背景脚本中使用了已弃用的 Manifest V2 API。
- React 组件中存在可能导致运行时错误的 bug,以及一些反模式的实践。
我已经将具体的修改建议以评论的形式附在相关代码行上。希望这些建议能帮助你提升代码质量。
|
放到 x6-extension 单独的 repo,大概率一年改不了几次,质量要求也可以低一些。 |
|
/gemini review |
Description
Motivation and Context
Types of changes
Self Check before Merge