chore: change default value of ENABLE_INTEL_MKL to OFF and trigger Python Build X86 on CMake changes#1806
Open
chore: change default value of ENABLE_INTEL_MKL to OFF and trigger Python Build X86 on CMake changes#1806
Conversation
…thon Build X86 in PR Agent-Logs-Url: https://github.com/antgroup/vsag/sessions/43c971b0-db46-4915-81b7-ebab4dc3090b Co-authored-by: wxyucs <12595343+wxyucs@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
wxyucs
April 8, 2026 08:47
View session
Agent-Logs-Url: https://github.com/antgroup/vsag/sessions/e0644b79-a474-4a07-bd2b-57cb6f34ba05 Co-authored-by: wxyucs <12595343+wxyucs@users.noreply.github.com>
Copilot
AI
requested review from
Copilot and
wxyucs
and removed request for
Copilot
April 8, 2026 08:57
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates VSAG’s build defaults to disable Intel MKL by default and refines PR CI change-detection so the x86 Python wheel build/test jobs run when Python or CMake/build-system files change.
Changes:
- Default
ENABLE_INTEL_MKL/VSAG_ENABLE_INTEL_MKLtoOFFin CMake + Makefile, and update developer docs accordingly. - Add a dedicated
cmakepaths-filter output in PR CI. - Trigger
Python Build X86andTest Python X86whenpythonorcmakechanges are detected.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Switches the Makefile default MKL toggle to OFF. |
| DEVELOPMENT.md | Updates documented default for ENABLE_INTEL_MKL to OFF. |
| cmake/VSAGOptions.cmake | Changes CMake option default for ENABLE_INTEL_MKL to OFF. |
| .github/workflows/pr-ci.yml | Adds cmake change detection and uses it to gate Python x86 build/test jobs. |
Comment on lines
110
to
114
| build-python-x86: | ||
| name: Python Build X86 | ||
| needs: [changes, format] | ||
| if: needs.changes.outputs.python == 'true' | ||
| if: needs.changes.outputs.python == 'true' || needs.changes.outputs.cmake == 'true' | ||
| runs-on: ubuntu-22.04 |
There was a problem hiding this comment.
The PR title indicates “Python Build X86” should trigger on C++ changes, but this if: condition only triggers on python or cmake path filters. Please align the PR title (or the condition) so the metadata matches the actual CI behavior and reviewers/users aren’t misled.
wxyucs
changed the title
wxyucs
added
version/1.0
kind/improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.github/workflows/pr-ci.ymlPython Build X86to trigger on Python changes or CMake-related changes onlyTest Python X86to match the same narrowed trigger condition