Send pushover notifications only when report status not good#212
Open
ThomasTr wants to merge 1 commit intoantedebaas:mainfrom
Open
Send pushover notifications only when report status not good#212ThomasTr wants to merge 1 commit intoantedebaas:mainfrom
ThomasTr wants to merge 1 commit intoantedebaas:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, I have stuck with the pushover notifications and have extended them so that they are only sent if the status is not good.
Sorry for the clutter, I have set phpstorm to clean up a lot of things (unnecessary tabs & spaces). This has led to a few more changes than actually necessary. Maybe you like to adopt the setting for yourself, is quite useful for clean code.