Skip to content

Correct handling of mac_address parameter#1231

Open
AAYUSH2091 wants to merge 8 commits intoansible-collections:mainfrom
AAYUSH2091:l3-interfaces-mac-address
Open

Correct handling of mac_address parameter#1231
AAYUSH2091 wants to merge 8 commits intoansible-collections:mainfrom
AAYUSH2091:l3-interfaces-mac-address

Conversation

@AAYUSH2091
Copy link
Copy Markdown
Contributor

@AAYUSH2091 AAYUSH2091 commented Sep 10, 2025

SUMMARY

This PR fixes a bug in the ios_l3_interfaces module where the mac_address parameter was being completely ignored.

Fixes #1220

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_l3_interfaces

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.55%. Comparing base (21adb74) to head (554146e).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files         224      224           
  Lines       13375    13359   -16     
=======================================
- Hits        11710    11696   -14     
+ Misses       1665     1663    -2     

see 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AAYUSH2091 AAYUSH2091 marked this pull request as ready for review October 13, 2025 10:33
@KB-perByte
Copy link
Copy Markdown
Collaborator

@AAYUSH2091, please check and work on getting this merged, is there a JIRA that this PR should be closing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test For network-integration jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mac_address not being configured by ios_l3_interfaces

4 participants