eos_acls: Fix missing 'standard' keyword in replaced state#613
eos_acls: Fix missing 'standard' keyword in replaced state#613PcInfamy wants to merge 3 commits intoansible-collections:mainfrom
Conversation
- Fix issue where state: replaced did not generate the standard keyword for standard ACLs - Refactor ACL command generation to pass full ACL object instead of individual ACEs - Add unit tests for both standard and extended ACL replacement - Resolves issue ansible-collections#608
86d9a5d to
319ee9c
Compare
|
|
@Ruchip16 Sorry for the headache - I messed up my previous PR. This one should be good to go. |
|
@PcInfamy thank you for the contribution , this looks good could you please ensure its rebased/updated |
@rohitthakur2590 ready! |
|
@PcInfamy thanks for the contribution! |
@rohitthakur2590 done! |
|
thank you , all tests passed successfully , but as other PR got merged before this one , you will have to again rebase this . |



SUMMARY
Fixes issue where
eos_aclsmodule withstate: replaceddid not generate thestandardkeyword for standard ACLs.When using
state: "replaced"on a standard ACL, the generated commands were missing thestandardkeyword (e.g.,ip access-list test-aclinstead ofip access-list standard test-acl). This caused the ACL to be created as an extended ACL instead of a standard one.The fix ensures that the
standardkey from the ACL configuration is properly passed to the command generation logic for new ACLs in replaced state.Fixes #608
ISSUE TYPE
COMPONENT NAME
eos_acls
ADDITIONAL INFORMATION
Before the fix:
Generated commands (incorrect):
After the fix:
Generated commands (correct):
Changes made:
_state_replacedinplugins/module_utils/network/eos/config/acls/acls.pyto pass the full ACL configuration (includingstandardkey) when creating new ACLstest_eos_acls_replaced_standardandtest_eos_acls_replaced_extended