Fix: Issue #573 Error message for field 'name' not filled#1160
Open
umichritikashetty wants to merge 4 commits intoanitab-org:developfrom
Open
Fix: Issue #573 Error message for field 'name' not filled#1160umichritikashetty wants to merge 4 commits intoanitab-org:developfrom
umichritikashetty wants to merge 4 commits intoanitab-org:developfrom
Conversation
|
Hello there!👋 Welcome to the project!💖 AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct. Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities. |
vj-codes
requested changes
Jan 18, 2023
Member
vj-codes
left a comment
There was a problem hiding this comment.
hey! your env variables are also pushed in the PR, can you please remove them, not needed here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #573
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
This was tested by inputting different strings (characters, empty strings, or strings with just spaces) in the name field and ensuring that the error message is always listed under the 400 section of error messages.
Checklist:
Code/Quality Assurance Only