Support variable length sgpd boxes in fMPEG#3178
Open
dimitry-unified-streaming wants to merge 1 commit intoandroidx:releasefrom
Open
Support variable length sgpd boxes in fMPEG#3178dimitry-unified-streaming wants to merge 1 commit intoandroidx:releasefrom
sgpd boxes in fMPEG#3178dimitry-unified-streaming wants to merge 1 commit intoandroidx:releasefrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
For `sgpd` boxes with version >= 1, `the default_length` field is zero if the length of the following sample group entries is variable. Since the `FragmentedMp4Extractor` only supports one entry, skip the `description_length` field if applicable (e.g. when version >= 1 and `default_length` == 0), instead of throwing an error. For parsing the following CencSampleEncryptionInformationGroupEntry, this should make no difference. Issue: androidx#3177
dimitry-unified-streaming
force-pushed
the
fix-variable-length-sgpd-1
branch
from
24b3c04 to
fc6df15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For
sgpdboxes with version >= 1,the default_lengthfield is zero if the length of the following sample group entries is variable.Since the
FragmentedMp4Extractoronly supports one entry, skip thedescription_lengthfield if applicable (e.g. when version >= 1 anddefault_length== 0), instead of throwing an error.For parsing the following CencSampleEncryptionInformationGroupEntry, this should make no difference.
Issue: #3177