Concurrent Downloads and Logging Improvements#2
Conversation
Signed-off-by: James Edward Bell Jr <[email protected]>
Signed-off-by: James Edward Bell Jr <[email protected]>
Signed-off-by: James Edward Bell Jr <[email protected]>
|
Cool! I ran this through AI so take this with a grain of salt but it came up with: Also, me personally, I kinda like it doing just one video at a time NOT in parallel. I don't want multiple ffmpeg's running eating up more CPU. And youtube will rate limit you if you do more than one so you end up getting the same effective download rate. |
Signed-off-by: James Edward Bell Jr <[email protected]>
Signed-off-by: James Edward Bell Jr <[email protected]>
|
Thanks @andrewarrow, I did some additional refactoring to make the queue depth/concurrency configurable. Running in different environments may yield different results for CPU (I ran the backend on a server specifically built for transcoding workloads 😅). I can confirm this still compiles, I made the response on |
👋 hi there, love the concept of the project. Just a quick PR I figured might be helpful. This should add concurrent download support (GIL may still be an issue for YT-DLP in the backend) and standardize logging through slog.
If this is helpful, I am happy to submit some other refactoring nice to haves!