ci: various build updates before adding Azure pipelines#92
Closed
ci: various build updates before adding Azure pipelines#92
Conversation
In recent versions, the '-y' argument isn't working/recognized and causes the build to fail. Don't use it for Homebrew, since it's not required. Signed-off-by: Alexandru Ardelean <[email protected]>
These builds haven't been working in a while. Remove them. Signed-off-by: Alexandru Ardelean <[email protected]>
Seems it was forgotten Signed-off-by: Alexandru Ardelean <[email protected]>
In order for this script to compile on Python3, the print function needs round braces. Signed-off-by: Alexandru Ardelean <[email protected]>
commodo
force-pushed
the
cleanup-build
branch
from
71904f0 to
88089fc
Compare
tfcollins
requested changes
Dec 10, 2020
Contributor
tfcollins
left a comment
tfcollins
left a comment
There was a problem hiding this comment.
Just want to wait to make sure it builds on Azure.
Contributor
Author
|
closing; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not great to merge things without CI, but this changeset is as small as possible.
It's disabling the Travis-CI build (wasn't building anyway).
And some minor tweaks.
Signed-off-by: Alexandru Ardelean [email protected]