Skip to content

Cache removal + shared call hierarchy engine extraction#46

Merged
amichne merged 4 commits intomainfrom
feature/extract-call-traversal-and-drop-git-sha-cache
Apr 10, 2026
Merged

Cache removal + shared call hierarchy engine extraction#46
amichne merged 4 commits intomainfrom
feature/extract-call-traversal-and-drop-git-sha-cache

Conversation

@amichne
Copy link
Copy Markdown
Owner

@amichne amichne commented Apr 10, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 5 additional findings.

Open in Devin Review

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 10 additional findings in Devin Review.

Open in Devin Review

Comment on lines 186 to 190
stmt.execute("DROP TABLE IF EXISTS file_metadata")
stmt.execute("DROP TABLE IF EXISTS file_manifest")
stmt.execute("DROP TABLE IF EXISTS workspace_discovery")
stmt.execute("DROP TABLE IF EXISTS call_hierarchy_cache")
stmt.execute("DROP TABLE IF EXISTS schema_version")
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 dropAllTables() omits DROP for call_hierarchy_cache, leaving orphaned table during v2→v3 migration

The call_hierarchy_cache table was removed from both createAllTables() and additiveMigration(), and the schema version was bumped from 2 to 3 to trigger a full rebuild. However, the corresponding DROP TABLE IF EXISTS call_hierarchy_cache was also removed from dropAllTables() at backend-standalone/src/main/kotlin/io/github/amichne/kast/standalone/cache/SqliteSourceIndexStore.kt:182-190. When an existing v2 database undergoes the schema mismatch migration (ensureSchema() at line 127-138 calls dropAllTables then createAllTables), the old call_hierarchy_cache table is never dropped and persists as an orphaned table with stale data. The DROP TABLE IF EXISTS is a no-op on databases that lack the table, so it's safe to keep.

(Refers to lines 182-190)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@amichne amichne merged commit 252730d into main Apr 10, 2026
4 checks passed
@amichne amichne deleted the feature/extract-call-traversal-and-drop-git-sha-cache branch April 10, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant